On Mon, Jan 11, 2016 at 07:32:36PM +0100, Kevin Wolf wrote: > bdrv_common_open() modified bs->open_flags after inferring the set of > options to pass to the driver's .bdrv_open callback. This means that the > cache options were correctly set in bs->open_flags (and therefore > correctly displayed in 'info block'), but the image would actually be > opened with the default cache mode instead. > > This patch removes the flags parameter to bdrv_common_open() (except for > BDRV_O_NO_BACKING it's the same as bs->open_flags anyway, and having two > names for the same thing is confusing), and moves the assignment of > open_flags down to immediately before calling into the block drivers. In > all other places, bs->open_flags is now used consistently. > > Signed-off-by: Kevin Wolf <kw...@redhat.com> > --- > block.c | 13 +++++++------ > 1 file changed, 7 insertions(+), 6 deletions(-)
Reviewed-by: Stefan Hajnoczi <stefa...@redhat.com>
signature.asc
Description: PGP signature
