On Mon, Feb 8, 2016 at 3:37 PM, Peter Maydell <peter.mayd...@linaro.org> wrote: > On 8 February 2016 at 23:24, Alistair Francis > <alistair.fran...@xilinx.com> wrote: >> This patch doesn't compile and neither does anything after this. I get >> the following errors: >> >> In file included from hw/sd/sd.c:35:0: >> /work/alistai/master-qemu/include/hw/sd/sd.h:81:5: error: unknown type >> name ‘DeviceClass’ >> DeviceClass parent_class; >> ^ >> /work/alistai/master-qemu/include/hw/sd/sd.h:99:14: error: field >> ‘qbus’ has incomplete type >> BusState qbus; >> ^ >> /work/alistai/master-qemu/include/hw/sd/sd.h:104:14: error: field >> ‘parent_class’ has incomplete type >> BusClass parent_class; >> ^ >> /work/alistai/master-qemu/rules.mak:57: recipe for target 'hw/sd/sd.o' failed >> make: *** [hw/sd/sd.o] Error 1 >> make: *** Waiting for unfinished jobs.... > > Weird. Maybe something's changed in include/ since I sent the series > so we're no longer getting qdev.h implicitly pulled in by some other > header.
I did rebase the patches ontop of the latest master, so that might be it. > > Does adding #include "hw/qdev.h" before the sd.h include in > sd.c fix this? Yeah, that fixes it. Thanks, Alistair > > thanks > -- PMM >
