On Mon, Jun 14, 2010 at 9:36 AM, Markus Armbruster <arm...@redhat.com> wrote: > Blue Swirl <blauwir...@gmail.com> writes: > >> Make APICState completely private to apic.c by using DeviceState >> in external APIs. > > Could you explain why this is an improvement?
Outside of apic.c, there is no need to access APICState fields so we can remove that privilege. We can move the device instantiation to the board level where it belongs.