On 03/03/2016 06:04 AM, Alex Bennée wrote:
Richard Henderson <r...@twiddle.net> writes:
On 02/22/2016 07:59 AM, Alex Bennée wrote:
+ qemu_set_dfilter_ranges("0x1000+0x100");
+
+ g_assert_false(qemu_log_in_addr_range(0xfff));
+ g_assert(qemu_log_in_addr_range(0x1000));
+ g_assert(qemu_log_in_addr_range(0x1100));
This is exactly what I was talking about wrt off-by-one error in my first
review -- 0x100 bytes, including 0x1000, finishes at 0x10ff.
This third test should fail.
OK so should 0x100+0x0 fail as it makes no sense, 0 bytes from 0x100 start?
Yes, I would think so.
r~
