Jason Wang, on Mon 07 Mar 2016 14:48:16 +0800, wrote: > - Lots of checkpatch warnings, let's try to silent it.
They are indentation issues, yes. They are already existing in slirp/ . Whenever new code was added we sticked with the qemu style, but for patched code we prefered to stick to the existing indentation, since otherwise it'd mean reindenting it all to keep the functions readable at all. Do you what to see the whole slirp directory be reindented once for good before this gets applied? Personally I just don't care which way or the other. > - The patches do not apply to master cleanly. It did at the time I sent them... > - I expects a unit-test for this. You may want to have a look at the > pxe-test in tests/, I think it could be extended to test ipv6 slirp somehow. It doesn't seem so simple to me. In the case of PXE, you have a guest implementation of PXE inside the BIOS. In the case of IPv6, I don't think you have a guest implementation of IPv6 in the BIOS... So we'd need to embed some guest that would do the IPv6 stuff. At best we can make a qtest_start(), and that's about it. I'm awfully tired of all of this. This work has been done 3 years ago, has already seen 9 iterations. Had it not been something important to my eyes (being able to easily test ipv6), I would have abandoned a long time ago. At the university of Bordeaux, we are planning to add a FOSS course with students participating to existing FOSS projects. I'm afraid we will just not be able to make them work on qemu at all. Samuel
