On 10/03/2016 10:41, Daniel P. Berrange wrote: >> > >> > https://github.com/bonzini/qemu/commit/win32-qio-watch^ > Since I made non-trivial changes to this commit, I thought it was > corrrect to remove your S-o-b, to avoid claiming that you'd already > signed off on the changes I made. Was that not the right thing > todo ?
You should have then also removed the authorship. I think in this case leaving the author and the s-o-b was the right thing to do, followed by removing the authorship and leaving the s-o-b. Signed-off-by is more of a legal thing than a "I think that these changes are good for QEMU". Paolo
