On 03/10/2016 02:54 AM, Paolo Bonzini wrote: > > > On 10/03/2016 10:41, Daniel P. Berrange wrote: >>>> >>>> https://github.com/bonzini/qemu/commit/win32-qio-watch^ >> Since I made non-trivial changes to this commit, I thought it was >> corrrect to remove your S-o-b, to avoid claiming that you'd already >> signed off on the changes I made. Was that not the right thing >> todo ? > > You should have then also removed the authorship. I think in this case > leaving the author and the s-o-b was the right thing to do, followed by > removing the authorship and leaving the s-o-b. Signed-off-by is more of > a legal thing than a "I think that these changes are good for QEMU".
I've seen this pattern of keeping original authorship and S-o-b, coupled with an extension to the commit message, in the qemu.git history, something like: original title original message S-o-b: original [make the following additional changes] S-o-b: second author -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
