At 2016-03-17 18:08:52, "Cornelia Huck" <cornelia.h...@de.ibm.com> wrote: >On Thu, 17 Mar 2016 17:20:29 +0800 >xiaoqiang zhao <zxq_yx_...@163.com> wrote: > >> Drop the DO_UPCAST macro >> >> Signed-off-by: xiaoqiang zhao <zxq_yx_...@163.com> >> --- >> hw/char/sclpconsole-lm.c | 14 +++++++++----- >> 1 file changed, 9 insertions(+), 5 deletions(-) >> >> diff --git a/hw/char/sclpconsole-lm.c b/hw/char/sclpconsole-lm.c >> index 7d4ff81..3dcc5a5 100644 >> --- a/hw/char/sclpconsole-lm.c >> +++ b/hw/char/sclpconsole-lm.c >> @@ -44,6 +44,10 @@ typedef struct SCLPConsoleLM { >> uint8_t buf[SIZE_CONSOLE_BUFFER]; >> } SCLPConsoleLM; >> >> +#define TYPE_SCLP_LM_CONSOLE "sclplmconsole" >> +#define SCLP_LM_CONSOLE(obj) \ >> + OBJECT_CHECK(SCLPConsoleLM, (obj), TYPE_SCLP_LM_CONSOLE) > >I'd prefer SCLPLM over SCLP_LM (don't know, but the 'LM' looks a bit >lonely ;) >
> Maybe better!