On Tue, Mar 22, 2016 at 07:28:13PM +0100, Markus Armbruster wrote: > Peter Xu <pet...@redhat.com> writes: > > diff --git a/scripts/qapi.py b/scripts/qapi.py > > index 6b2aa6e..716474e 100644 > > --- a/scripts/qapi.py > > +++ b/scripts/qapi.py > > @@ -46,6 +46,7 @@ returns_whitelist = [ > # Whitelist of commands allowed to return a non-dictionary > returns_whitelist = [ > 'human-monitor-command', > 'qom-get', > 'query-migrate-cache-size', > > 'query-tpm-models', > > 'query-tpm-types', > > 'ringbuf-read', > > + 'query-gic-capability', > > > > # From QGA: > > 'guest-file-open', > > The whitelist exists to except existing commands from design rules on > return types. New commands don't get to violate the rules without a > really, really compelling reason. > > Do you actually need this? > > If yes, why should your command be permitted to violate the design > rules?
This might not be required. Agree with you and Eric. Will use a hash instead with single key. > > +#include "qemu/osdep.h" > > +#include "hw/boards.h" > > +#include "qemu/error-report.h" > > +#include "sysemu/kvm.h" > > +#include "qmp-commands.h" > > I very much doubt you need all these includes. Try dropping all but the > first and the last one. I just copied them from machine.c and dropped lots, seems still redundant... Will keep it a minimum subset in next version. Thanks! -- peterx
