On 03/23/2016 08:06 AM, Markus Armbruster wrote: >>> query-gic-capabilities looks like it fundamentally returns a list of >>> capabilities. Returning ['GICCapability'] is just fine then. >> >> I have posted v6 just as Eric has suggested. At least one advantage >> is that it is easier to be extended (if needed) in the future, also >> to follow the more-generic format to use dicts rather than >> arrays. If you would not mind, I'll keep the dict interface there. > > Returning such a list of a structured type is a well-established > convention by now --- qmp-introspect.c shows 28 commands doing it, most > of them named query-FOO. I'd rather not start a different convention > now, just because we got temporarily confused about our own rules. So, > unless there's something about query-gic-capabilities that makes it more > likely to need extension outside its list element type, let's stick to > returning the list. > > Eric?
Makes sense to me, and perhaps my own fault for getting confused by not even trying to delete just the whitelist line and seeing what would happen. Having a consistent style of query-* returning an array type is reasonable to continue. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
