On Mon, Apr 4, 2016 at 10:14 PM, Peter Maydell <peter.mayd...@linaro.org> wrote: > On 4 April 2016 at 17:40, Vijay Kilari <vijay.kil...@gmail.com> wrote: >> On Mon, Apr 4, 2016 at 7:14 PM, Peter Maydell <peter.mayd...@linaro.org> >> wrote: >>> I agree that this would definitely improve performance (both for >>> migration and for emulated guests), but I'm afraid this breaks >>> running 32-bit ARMv5 and ARMv7M guests with this QEMU binary, >>> so we can't do this. If we want to allow the minimum page size to >>> be bigger than 1K for AArch64 CPUs then we need to make it a >>> runtime settable thing rather than compile-time (which is not >>> an entirely trivial thing). >> >> Do you mean to say that based on -cpu type qemu option >> choose the page size at runtime? > > If you want to avoid defining TARGET_PAGE_SIZE to the > lowest-common-denominator 1K, then yes, you'd need to > choose it at runtime. That could be painful to implement.
Had a look at it. Needs some changes in common code as well. I will send this as a separate patch series and drop this patch from this series. > > thanks > -- PMM
