On 05/09/2016 03:29 AM, Paolo Bonzini wrote: > > > On 09/05/2016 10:50, Paolo Bonzini wrote: >> >> >> On 29/04/2016 06:23, Eric Blake wrote: >>> Note that the series has a mutually exclusive choice: either >>> patch 8, or patches 10-11. I still haven't gotten any feedback >>> on which choice seems nicer. >> >> I vote for patch 8. > > Nice first email after 3 weeks, I meant exactly the opposite. :) Having > two APIs for the same thing is unnecessary. > > However, including all of patches 8/10/11 may also make sense (and > leaving out the revert). Then qjson is migrated first, then its users > move away from qjson, then qjson is removed.
You'll want to catch up on the rest of the thread - for now, v4 of this series will drop 8-11 entirely, because Dave was unwilling to accept any new assertions on the migration path, so we instead moved qjson.c under migration/ and added explicit comments why it is duplicating a rudimentary JSON output engine but with no error checking or assertions. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
