On Fri, Jun 17, 2016 at 2:09 PM, Richard Henderson <r...@twiddle.net> wrote: > On 06/17/2016 11:07 AM, Pranith Kumar wrote: >> On Fri, Jun 17, 2016 at 2:04 PM, Paolo Bonzini <pbonz...@redhat.com> wrote: >>> >>> >>> On 16/06/2016 21:07, Richard Henderson wrote: >>>>> && ((addr >> 41) & 3) == 2 >>>>> - && addr >> TARGET_VIRT_ADDR_SPACE_BITS == addr >> 63); >>>>> + && addr >> TARGET_VIRT_ADDR_SPACE_BITS == 1); >>> >>> What you want here is >>> >>> + addr >> TARGET_VIRT_ADDR_SPACE_BITS == -1 >>> >>> since that's what addr >> 63 is. With this change the patch should be fine. >> >> Isn't (addr >> 63) supposed to be 1? How can it be -1? > > Signed right shift.
Ah, got it. :) > > I'll prepare a patch for all of this. Thanks! -- Pranith
