On Tue, Sep 6, 2016 at 6:52 PM, Ashijeet Acharya <ashijeetacha...@gmail.com> wrote: > On Tue, Sep 6, 2016 at 4:32 PM, Dr. David Alan Gilbert > <dgilb...@redhat.com> wrote: >> * Ashijeet Acharya (ashijeetacha...@gmail.com) wrote: >>> Mark old-commands for speed and downtime as deprecated. >>> Move max-bandwidth and downtime-limit into migrate-set-parameters for >>> setting maximum migration speed and expected downtime limit parameters >>> respectively. >>> Change downtime units to milliseconds (only for new-command) and update >>> the query part in both hmp and qmp qemu control interfaces. >>> >>> Signed-off-by: Ashijeet Acharya <ashijeetacha...@gmail.com> >>> --- >>> hmp.c | 27 ++++++++++ >>> include/migration/migration.h | 1 - >>> migration/migration.c | 120 >>> ++++++++++++++++++++++++++++++++---------- >>> qapi-schema.json | 33 ++++++++++-- >>> qmp-commands.hx | 14 +++-- >>> 5 files changed, 159 insertions(+), 36 deletions(-) >>> >>> @@ -642,7 +648,7 @@ MigrationInfo *qmp_query_migrate(Error **errp) >>> info->total_time = qemu_clock_get_ms(QEMU_CLOCK_REALTIME) >>> - s->total_time; >>> info->has_expected_downtime = true; >>> - info->expected_downtime = s->expected_downtime; >>> + info->expected_downtime = s->expected_downtime / 1000; >> >> I don't understand this change here; why are we changing the output >> scale here? > > If i don't do that and the
Sorry, I forgot to complete that. I got my mistake and I will revert it to original. Thanks Ashijeet >> -- >> Dr. David Alan Gilbert / dgilb...@redhat.com / Manchester, UK
