Hi Markus,

On 2016/9/22 下午7:56, Markus Armbruster wrote:
Xiao Long Jiang <zxi...@linux.vnet.ibm.com> writes:

This fixes a Qemu crash that introduced by commit ad73970
("qom: Wrap prop visit in visit_start_struct").

Not all of the callers of user_creatable_add_type always pass qdict,
so we should check qdict against NULL, but not raise an assertion.

The problem can be easily triggered by adding an iothread with:
   $ virsh iothreadadd <domain> <threadid>
In which the <threadid> is newly defined. The result of the command
will return an error and cause the running guest crash.

Cc: Eric Blake <ebl...@redhat.com>
Cc: Markus Armbruster <arm...@redhat.com>
Signed-off-by: Xiao Long Jiang <zxi...@linux.vnet.ibm.com>
Reviewed-by: Dong Jia Shi <bjsdj...@linux.vnet.ibm.com>
Marc-André already posted a simpler fix:
Subject: [PATCH] qmp: fix object-add assert() without props
Message-Id: <20160921194126.10223-1-marcandre.lur...@redhat.com>

Would you be willing to test it?  Review would of course also be


Have tested that patch. It works fine on arch s390 system.

Reply via email to