On Fri, Sep 23, 2016 at 09:16:35AM -0500, Eric Blake wrote: > On 09/23/2016 06:07 AM, Daniel P. Berrange wrote: > > >>> - error_setg(errp, QERR_INVALID_PARAMETER_VALUE, > >>> - name, "'on' or 'off'"); > >>> + error_setg(errp, QERR_INVALID_PARAMETER_VALUE, name, > >>> + "on|yes|y|off|no|n"); > >> > >> This change requires an update to the reference output of some > >> qemu-iotests (at least 051 and 137). > > > > Opps, yes, so it does. > > Do any of the docker tests or buildbots catch this automatically? (I > often forget to run qemu-iotests, since they are not part of 'make check')
FWIW, as mentioned here: https://lists.gnu.org/archive/html/qemu-devel/2016-09/msg04392.html I've tried adding qemu-iotests to our travis config for raw, qcow2 and luks, but hit many non-deterministic failures in it. We'll have to get it stable under high load before we can have it run automatically unless we want high false-failure rate. Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
