On Thu, Sep 22, 2016 at 02:49:35PM -0500, Corey Minyard wrote: > On 09/22/2016 01:42 PM, Eduardo Habkost wrote: [...] > > In the case of the inject-nmi QMP command, I need to understand > > what "default CPU" is supposed to mean in the inject-nmi > > documentation. Maybe it can be changed to use the first CPU, too > > (that's probably the existing behavior because there's no way to > > change cur_mon->mon_cpu in a QMP monitor). > > > I looked through is a bit, and the only place I found it was used was > the x390 code. > > If we remove the CPU index from this, then the IPMI device can > keep the same interface.
Well, the existing behavior is to use the first CPU, so I will just keep the existing behavior but remove the monitor_get_cpu_index() call from qmp_inject_nmi(). Then the IPMI code can stay the same. -- Eduardo
