On 07.10.2016 17:38, Kevin Wolf wrote: > Now that QAPI supports boxed types, we can have unions at the top level > of a command, so let's put our real options directly there for > blockdev-add instead of having a single "options" dict that contains the > real arguments. > > blockdev-add is still experimental and we already made substantial > changes to the API recently, so we're free to make changes like this > one, too. > > Signed-off-by: Kevin Wolf <kw...@redhat.com> > --- > > Yes, that's right. Ignoring the test cases, this is a one-liner in > the schema without any C code changes. :-)
While that is cool and correct, you also ignored the documentation changes, which is probably not correct. :-) (There are some blockdev-add examples in docs/qmp-commands.txt which need to be adjusted.) Max
signature.asc
Description: OpenPGP digital signature
