Re: [Qemu-devel] [PATCH] colo-compare: remove unused struct CompareChardevProps and 'props' variable

[Zhang Chen]

On 10/13/2016 02:57 PM, zhanghailiang wrote:

After commit 0a73336d, 'props' variable in find_and_check_chardev()
is unused. Remove it, togther with struct CompareChardevProps.

Signed-off-by: zhanghailiang <zhang.zhanghaili...@huawei.com>

Reviewed-by: Zhang Chen <zhangchen.f...@cn.fujitsu.com>

Thanks
Zhang Chen

---
  net/colo-compare.c | 8 --------
  1 file changed, 8 deletions(-)

diff --git a/net/colo-compare.c b/net/colo-compare.c
index 47703c5..4be6fc3 100644
--- a/net/colo-compare.c
+++ b/net/colo-compare.c
@@ -92,10 +92,6 @@ typedef struct CompareClass {
      ObjectClass parent_class;
  } CompareClass;

-typedef struct CompareChardevProps {

-    bool is_socket;
-} CompareChardevProps;
-
  enum {
      PRIMARY_IN = 0,
      SECONDARY_IN,
@@ -573,8 +569,6 @@ static int find_and_check_chardev(CharDriverState **chr,
                                    char *chr_name,
                                    Error **errp)
  {
-    CompareChardevProps props;
-
      *chr = qemu_chr_find(chr_name);
      if (*chr == NULL) {
          error_setg(errp, "Device '%s' not found",
@@ -582,8 +576,6 @@ static int find_and_check_chardev(CharDriverState **chr,
          return 1;
      }

- memset(&props, 0, sizeof(props));

-
      if (!qemu_chr_has_feature(*chr, QEMU_CHAR_FEATURE_RECONNECTABLE)) {
          error_setg(errp, "chardev \"%s\" is not reconnectable",
                     chr_name);

--
Thanks
zhangchen