On Wed, Oct 12, 2016 at 06:13:50PM -0500, Michael Roth wrote: > Currently we access individual bytes of an option vector via > ldub_phys() to test for the presence of a particular capability > within that byte. Currently this is only done for the "dynamic > reconfiguration memory" capability bit. If that bit is present, > we pass a boolean value to spapr_h_cas_compose_response() > to generate a modified device tree segment with the additional > properties required to enable this functionality. > > As more capability bits are added, will would need to modify the > code to add additional option vector accesses and extend the > param list for spapr_h_cas_compose_response() to include similar > boolean values for these parameters. > > Avoid this by switching to spapr_ovec_* helpers so we can do all > the parsing in one shot and then test for these additional bits > within spapr_h_cas_compose_response() directly. > > Cc: Bharata B Rao <bhar...@linux.vnet.ibm.com> > Signed-off-by: Michael Roth <mdr...@linux.vnet.ibm.com>
Nicely done! Reviewed-by: Bharata B Rao <bhar...@linux.vnet.ibm.com> Regards, Bharata.