On 10/16/2016 03:17 PM, Emilio G. Cota wrote:
> +/* Note that for addition, we need to use a separate cmpxchg loop instead > + of bswaps for the reverse-host-endian helpers. */ > +ABI_TYPE ATOMIC_NAME(fetch_add)(CPUArchState *env, target_ulong addr, > + ABI_TYPE val EXTRA_ARGS) > +{ > + DATA_TYPE *haddr = ATOMIC_MMU_LOOKUP; > + DATA_TYPE ldo, ldn, ret, sto; > + > + ldo = *haddr;ldo = atomic_read(haddr) would be better here for C11 compliance (or tsan will complain).
Good point. Fixed. r~
