Re: [Qemu-devel] [PATCH v6 13/35] tcg: Add atomic helpers

[Richard Henderson]

On 10/16/2016 03:17 PM, Emilio G. Cota wrote:

+#if DATA_SIZE == 1
> +# define END
> +#elif defined(HOST_WORDS_BIGENDIAN)
> +# define END  _be
> +#else
> +# define END  _le
> +#endif

It took me a while to figure out that ATOMIC_NAME needs END (ATOMIC_NAME
is defined later in the patch).

It might be clearer to pass it explicitly as a suffix in the macro, as in
#define ATOMIC_NAME(name, suffix) to then have ATOMIC_NAME(cmpxchg, END).

Hum.  Perhaps a comment?

r~