On 21/10/16 23:02, Benjamin Herrenschmidt wrote: > On Fri, 2016-10-21 at 15:18 +0100, Mark Cave-Ayland wrote: >> >> bd6fefe71cec5a0c7d2be4ac96307f25db56abf9 is the first bad commit >> commit bd6fefe71cec5a0c7d2be4ac96307f25db56abf9 >> Author: Benjamin Herrenschmidt <b...@kernel.crashing.org> >> Date: Wed Jul 27 16:56:32 2016 +1000 >> >> ppc: Make tlb_fill() use new exception helper >> >> Signed-off-by: Benjamin Herrenschmidt <b...@kernel.crashing.org> >> Signed-off-by: David Gibson <da...@gibson.dropbear.id.au> >> >> :040000 040000 3494b2d68eef71c8f7c7d4e57c5ff715146028b2 >> 00849bf5889d8ee5b5ce633122b7aedf4a734372 M linux-user >> :040000 040000 32b1a8078a44c44e6bfd2184061b6da553cfc821 >> 58afefec7a9fc5380fb408758a11dbe749010b97 M target-ppc > > Hrm, that patch does a lot more that the subject (and lack of cset > comment) implies. I wonder if it got some rebase damage here.
Indeed, it looks like extra changes were squashed into that single patch between these two pull requests: 6th September: https://lists.gnu.org/archive/html/qemu-devel/2016-09/msg00887.html 7th September: https://lists.gnu.org/archive/html/qemu-devel/2016-09/msg01465.html > In the meantime, look at 24a2d2ac2cfbb699cab216aaf118c8503f22817c > " ppc: Fix single step with gdb stub" in my wip branch, see if that > helps. Yes it does - I've cherry-picked this onto master and I can confirm that it fixes the gdbstub issues I was seeing here. David, any chance we can we get this queued into your ppc-for-2.8 branch? ATB, Mark.
