On 10/27/2016 05:45 AM, Fam Zheng wrote: > It is too confusing because it sounds like a BDRVRawState variable. > > Suggested-by: Max Reitz <mre...@redhat.com> > Signed-off-by: Fam Zheng <f...@redhat.com> > --- > block/raw-posix.c | 56 > +++++++++++++++++++++++++++---------------------------- > 1 file changed, 28 insertions(+), 28 deletions(-) > > diff --git a/block/raw-posix.c b/block/raw-posix.c > index f481e57..7c62fc3 100644 > --- a/block/raw-posix.c > +++ b/block/raw-posix.c > @@ -542,7 +542,7 @@ static int raw_reopen_prepare(BDRVReopenState *state, > BlockReopenQueue *queue, Error **errp) > { > BDRVRawState *s; > - BDRVRawReopenState *raw_s; > + BDRVRawReopenState *rs;
Would rrs (Raw Reopen State) be any better? But you can ignore my bikeshedding. The patch is mechanical, so either spelling gets: Reviewed-by: Eric Blake <ebl...@redhat.com> -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature