On 01/04/2017 08:59 AM, Paolo Bonzini wrote: > options must be non-NULL here, because a NULL value is replaced with > qdict_new earlier in the function. Reported by Coverity. > > Signed-off-by: Paolo Bonzini <[email protected]> > --- > block.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Eric Blake <[email protected]> > > diff --git a/block.c b/block.c > index 39ddea3..a0346c8 100644 > --- a/block.c > +++ b/block.c > @@ -1851,7 +1851,7 @@ static BlockDriverState *bdrv_open_inherit(const char > *filename, > bdrv_refresh_filename(bs); > > /* Check if any unknown options were used */ > - if (options && (qdict_size(options) != 0)) { > + if (qdict_size(options) != 0) { > const QDictEntry *entry = qdict_first(options); > if (flags & BDRV_O_PROTOCOL) { > error_setg(errp, "Block protocol '%s' doesn't support the option > " > -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
