Re: [Qemu-devel] [PATCH v2 01/11] aspeed/smc: remove call to reset in realize function

[mar.krzeminski]

W dniu 09.01.2017 o 17:24, Cédric Le Goater pisze:

This is useless as reset will be called later on.

Signed-off-by: Cédric Le Goater <c...@kaod.org>

Acked-by: Marcin Krzemiński <mar.krzemin...@gmail.com>

---
  hw/ssi/aspeed_smc.c | 2 --
  1 file changed, 2 deletions(-)

diff --git a/hw/ssi/aspeed_smc.c b/hw/ssi/aspeed_smc.c
index 78f5aed53247..8a7217d4df6c 100644
--- a/hw/ssi/aspeed_smc.c
+++ b/hw/ssi/aspeed_smc.c
@@ -541,8 +541,6 @@ static void aspeed_smc_realize(DeviceState *dev, Error 
**errp)
          sysbus_init_irq(sbd, &s->cs_lines[i]);
      }

- aspeed_smc_reset(dev);

-
      /* The memory region for the controller registers */
      memory_region_init_io(&s->mmio, OBJECT(s), &aspeed_smc_ops, s,
                            s->ctrl->name, ASPEED_SMC_R_MAX * 4);