"Michael S. Tsirkin" <m...@redhat.com> writes:
> All users include the trailing ;, let's require that
> so that uses such as if (a) QEMU_BUILD_BUG_ON(); do not
> produce unexpected results.
>
> Not a huge problem for QEMU since our style requires the use
> of {} but seems cleaner nevertheless.
I think the actual problem is that it sets a bad example.
> Signed-off-by: Michael S. Tsirkin <m...@redhat.com>
> ---
> include/qemu/compiler.h | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/include/qemu/compiler.h b/include/qemu/compiler.h
> index 157698b..2882470 100644
> --- a/include/qemu/compiler.h
> +++ b/include/qemu/compiler.h
> @@ -86,7 +86,8 @@
> #define type_check(t1,t2) ((t1*)0 - (t2*)0)
>
> #define QEMU_BUILD_BUG_ON(x) \
> - typedef char glue(qemu_build_bug_on__,__LINE__)[(x)?-1:1]
> __attribute__((unused));
> + typedef char glue(qemu_build_bug_on__,__LINE__)[(x) ? -1 : 1] \
> + __attribute__((unused))
>
> #if defined __GNUC__
> # if !QEMU_GNUC_PREREQ(4, 4)
Preferably with the commit message clarified a bit:
Reviewed-by: Markus Armbruster <arm...@redhat.com>
