On Fri, Jan 27, 2017 at 6:51 AM, Thomas Huth <th...@redhat.com> wrote:
> The "or-irq" device is just used internally. It's strange to
> see this device showing up in the "-device ?" help text. Let's mark it
> with cannot_instantiate_with_device_add_yet to hide it from the users.
I agree that it is strange to be showing up to users, but is this
really the best way to do this?
I thought we were trying to get rid of
cannot_instantiate_with_device_add_yet. Would it maybe be better to
have an internal filed that sets this device as internal?
Thanks,
Alistair
>
> Signed-off-by: Thomas Huth <th...@redhat.com>
> ---
> hw/core/or-irq.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/hw/core/or-irq.c b/hw/core/or-irq.c
> index 1ac090d..2487fa3 100644
> --- a/hw/core/or-irq.c
> +++ b/hw/core/or-irq.c
> @@ -89,6 +89,9 @@ static void or_irq_class_init(ObjectClass *klass, void
> *data)
> dc->props = or_irq_properties;
> dc->realize = or_irq_realize;
> dc->vmsd = &vmstate_or_irq;
> +
> + /* It's just used internally, and should not be exposed to users */
> + dc->cannot_instantiate_with_device_add_yet = true;
> }
>
> static const TypeInfo or_irq_type_info = {
> --
> 1.8.3.1
>
>
