On 27 January 2017 at 16:40, Alistair Francis <alistair.fran...@xilinx.com> wrote: > On Fri, Jan 27, 2017 at 6:51 AM, Thomas Huth <th...@redhat.com> wrote: >> The "or-irq" device is just used internally. It's strange to >> see this device showing up in the "-device ?" help text. Let's mark it >> with cannot_instantiate_with_device_add_yet to hide it from the users. > > I agree that it is strange to be showing up to users, but is this > really the best way to do this? > > I thought we were trying to get rid of > cannot_instantiate_with_device_add_yet. Would it maybe be better to > have an internal filed that sets this device as internal?
Yes, I agree; the reason for cannot_instantiate_with_device_add_yet being such a long and ugly name is so it's easy to grep for things we in theory might want to fix some day. "We'd rather this didn't show up in help" is a different question. (Like a lot of devices, it's pretty useless via -device, though, because we have no way to wire up qemu_irq lines on the command line.) thanks -- PMM
