On 01/27/2017 09:59 PM, Nir Soffer wrote: > From: Nir Soffer <nsof...@redhat.com> > > Many tests expected the wrong behavior when qemu-io call into the > command with after failing to open the file, writing this error: > > no file open, try 'help open' > > Now that we fail immediately when opening a file fails, this error does > not exist in the output; remove it from tests output.
Ideally, this should be squashed into the patch that changes the output (so that a git bisect landing on the change in behavior does not hit unnecessarily-broken tests). > > Tested using: > > ./check 059 -vmdk (unrelated failure) > ./check 070 -vhdx > ./check 075 -cloop > ./check 076 -parallels > ./check 078 -bochs > ./check 080 -qcow2 > ./check 083 -nbd > ./check 088 -vpc > ./check 092 -qcow > ./check 116 -qed > ./check 131 -parallels > ./check 140 -raw > ./check 140 -qcow2 > ./check -raw > ./check -qcow2 > > Signed-off-by: Nir Soffer <nir...@gmail.com> > --- > tests/qemu-iotests/059.out | 3 --- > tests/qemu-iotests/070.out | 1 - > tests/qemu-iotests/075.out | 7 ------- > tests/qemu-iotests/076.out | 3 --- > tests/qemu-iotests/078.out | 6 ------ > tests/qemu-iotests/080.out | 18 ------------------ > tests/qemu-iotests/083.out | 17 ----------------- > tests/qemu-iotests/088.out | 6 ------ > tests/qemu-iotests/092.out | 12 ------------ > tests/qemu-iotests/116.out | 7 ------- > tests/qemu-iotests/131.out | 1 - > tests/qemu-iotests/140.out | 1 - > 12 files changed, 82 deletions(-) > The changes look reasonable, once squashed in to the right place; looking forward to v4. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature