On Fri, Feb 17, 2017 at 03:40:21PM -0600, Eric Blake wrote: > On 01/25/2017 11:42 AM, Jeff Cody wrote: > > From: Kevin Wolf <kw...@redhat.com> > > > > This adds blockdev-add support for iscsi devices. > > > > Reviewed-by: Daniel P. Berrange <berra...@redhat.com> > > Signed-off-by: Kevin Wolf <kw...@redhat.com> > > Signed-off-by: Jeff Cody <jc...@redhat.com> > > --- > > block/iscsi.c | 14 ++++++---- > > qapi/block-core.json | 74 > > ++++++++++++++++++++++++++++++++++++++++++++++++---- > > 2 files changed, 78 insertions(+), 10 deletions(-) > > > +++ b/qapi/block-core.json > > @@ -2116,10 +2116,10 @@ > > { 'enum': 'BlockdevDriver', > > 'data': [ 'archipelago', 'blkdebug', 'blkverify', 'bochs', 'cloop', > > 'dmg', 'file', 'ftp', 'ftps', 'gluster', 'host_cdrom', > > - 'host_device', 'http', 'https', 'luks', 'nbd', 'nfs', > > 'null-aio', > > - 'null-co', 'parallels', 'qcow', 'qcow2', 'qed', 'quorum', > > 'raw', > > - 'replication', 'ssh', 'vdi', 'vhdx', 'vmdk', 'vpc', > > - 'vvfat' ] } > > + 'host_device', 'http', 'https', 'iscsi', 'luks', 'nbd', 'nfs', > > + 'null-aio', 'null-co', 'parallels', 'qcow', 'qcow2', 'qed', > > + 'quorum', 'raw', 'replication', 'ssh', 'vdi', 'vhdx', 'vmdk', > > + 'vpc', 'vvfat' ] } > > Are we missing a since 2.9 documentation designation here? >
Yes, thanks for catching that. I've applied it to my branch already, but I will go ahead and fix this and rebase with the following squashed into the patch: diff --git a/qapi/block-core.json b/qapi/block-core.json index f00fc9d..5f82d35 100644 --- a/qapi/block-core.json +++ b/qapi/block-core.json @@ -2110,6 +2110,7 @@ # @nfs: Since 2.8 # @replication: Since 2.8 # @ssh: Since 2.8 +# @iscsi: Since 2.9 # # Since: 2.0 ##