On 04/26/2017 04:42 AM, David Gibson wrote: > On Tue, Apr 25, 2017 at 08:51:41AM +0200, Cédric Le Goater wrote: >> Currenlty, the code relies on the fact that open() handles NULL >> filenames but that can cause an error with new clang: >> >> hw/core/loader.c:67:15: runtime error: null pointer passed as argument 1, >> which is declared to never be null >> >> Signed-off-by: Cédric Le Goater <c...@kaod.org> > > Since my ppc-for-2.10 pull request has been held up because of this > anyway, tather than just apply this on top, I've folded it into your > earlier patch which caused the bug - that way we won't break bisect.
Yes that is the best option. Thanks, C.