On 05/08/2017 11:42 AM, Stefan Hajnoczi wrote: > On Fri, May 05, 2017 at 08:34:42AM +0200, Markus Armbruster wrote: >> [v2]: Fix trailing space, note tweaks to PATCH 12 properly in the >> >> commit message >> The following changes since commit e619b14746e5d8c0e53061661fd0e1da01fd4d60: >> >> Merge remote-tracking branch 'sthibault/tags/samuel-thibault' into staging >> (2017-05-02 15:16:29 +0100) >> >> are available in the git repository at: >> >> git://repo.or.cz/qemu/armbru.git tags/pull-qapi-2017-05-04-v2 > > make check fails when I apply this series: > > GTESTER tests/test-char > GTester: last random seed: R02S47a681e3e741223084711f7aacacb19a > GTester: last random seed: R02S739de30ffeb0f93caedc22b2863f60a7
I tried bisecting, and I hit compilation failures during:
sockets: Rename SocketAddress to SocketAddressLegacy
chardev/char-socket.c: In function ‘qmp_chardev_open_socket’:
chardev/char-socket.c:948:13: error: implicit declaration of function
‘qapi_free_SocketAddress’ [-Werror=implicit-function-declaration]
qapi_free_SocketAddress(s->addr);
^~~~~~~~~~~~~~~~~~~~~~~
and
sockets: Rename SocketAddressFlat to SocketAddress
chardev/char-socket.c: In function ‘qmp_chardev_open_socket’:
chardev/char-socket.c:948:37: error: passing argument 1 of
‘qapi_free_SocketAddress’ from incompatible pointer type
[-Werror=incompatible-pointer-types]
qapi_free_SocketAddress(s->addr);
^
which places the failure(s) anywhere in this range:
pick 70ae657 qapi: New QAPI_CLONE_MEMBERS()
pick f031ce2 sockets: Rename SocketAddress to SocketAddressLegacy
pick b1eb5e0 sockets: Rename SocketAddressFlat to SocketAddress
pick a842861 sockets: Limit SocketAddressLegacy to external interfaces
I don't see the failures when testing armbru/qapi-next in isolation.
Probably just means you have to rebase your series on top of
Marc-André's series which got merged first, although such a rebase is
not necessarily trivial :(
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
