On 05/12/2017 08:31 AM, Alexey Perevalov wrote: > The rationale for that idea is following: > vCPU could suspend during postcopy live migration until faulted > page is not copied into kernel. Downtime on source side it's a value - > time interval since source turn vCPU off, till destination start runnig > vCPU. But that value was proper value for precopy migration it really shows > amount of time when vCPU is down. But not for postcopy migration, because > several vCPU threads could susppend after vCPU was started. That is important > to estimate packet drop for SDN software. > > This is 5th version of patch set. In previous was build error in mingw. > First version was tagged as RFC, second was without version tag, third with > V3. > > This patch set doesn't include improvements sugested by Peter Xu for > get_mem_fault_cpu_index, but I would prefer to do it. I think to introduce a > tree for fast CPUState lookup by thread_id, or general code, due to there are > places like qemu_get_cpu (cpus.c) with the similar lookup. > > (V4 -> V5) > - fill_destination_postcopy_migration_info empty stub was missed for none > linux > build > > (V3 -> V4)
I reviewed a couple of spots related to QMP in v4 before seeing that you had already posted v5; those comments still apply. -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
