Juan Quintela <quint...@redhat.com> writes:
> We have change in the previous patch to use migration capabilities for
> it. Notice that we continue using the old command line flags from
> migrate command from the time being. Remove the set_params method as
for the time being
> now it is empty.
>
> For savevm, one can't do a:
>
> savevm -b/-i foo
>
> but now one can do:
>
> migrate_set_capability block on
> savevm foo
>
> And we can't use block migration. We could disable block capability
> unconditionally, but it would not be much better.
I think I get what you're trying to say, but only because I have plenty
of context right now. Let me try to rephrase:
migration: Use new configuration instead of old MigrationParams
The previous commit introduced a MigrationCapability and a
MigrationParameter for block migration. Use them instead of the old
MigrationParams.
Take care to reject attempts to combine block migration with
snapshots, e.g. like this:
migrate_set_capability block on
savevm foo
> Signed-off-by: Juan Quintela <quint...@redhat.com>
Preferably with a commit message I can still understand three weeks from
now:
Reviewed-by: Markus Armbruster <arm...@redhat.com>
