On Mon, Jun 05, 2017 at 03:22:24PM -0500, Eric Blake wrote:
> On 05/19/2017 01:43 AM, Peter Xu wrote:
> > We were do the shutting off only for postcopy. Now we do this as long as
> > the source return path is there.
> >
> > Moving the cleanup of from_src_file there too.
> >
> > Signed-off-by: Peter Xu <pet...@redhat.com>
> > ---
> > migration/migration.c | 8 +++++++-
> > migration/postcopy-ram.c | 1 -
> > 2 files changed, 7 insertions(+), 2 deletions(-)
>
> This commit causes a regression in qemu-iotests 68:
>
> $ cd tests/qemu-iotests
> $ ./check -qcow2 68
> ...
> 068 1s ... - output mismatch (see 068.out.bad)
> --- /home/eblake/qemu-tmp2/tests/qemu-iotests/068.out 2017-05-30
> 09:27:26.795821748 -0500
> +++ 068.out.bad 2017-06-05 15:21:18.566816816 -0500
> @@ -6,6 +6,8 @@
> QEMU X.Y.Z monitor - type 'help' for more information
> (qemu) savevm 0
> (qemu) quit
> +./common.config: line 107: 1912 Segmentation fault (core dumped)
> ( if [ -n "${QEMU_NEED_PID}" ]; then
> + echo $BASHPID > "${QEMU_TEST_DIR}/qemu-${_QEMU_HANDLE}.pid";
> +fi; exec "$QEMU_PROG" $QEMU_OPTIONS "$@" )
> QEMU X.Y.Z monitor - type 'help' for more information
> -(qemu) quit
> -*** done
> +(qemu) *** done
> Failures: 068
> Failed 1 of 1 tests
>
> I didn't investigate further; but am hoping you'll be able to fix the
> segfault and get the test working again.
Sorry for that! I will have a look.
--
Peter Xu
