On Fri, Jun 09, 2017 at 04:02:37PM +0200, Markus Armbruster wrote: > Test compile gripes: > > hw/xen/xen-common.c: In function ‘xen_init’: > hw/xen/xen-common.c:147:5: warning: implicit declaration of function > ‘register_compat_prop’ [-Wimplicit-function-declaration] > register_compat_prop("migration", "store-global-state", "off"); > ^~~~~~~~~~~~~~~~~~~~ > hw/xen/xen-common.c:147:5: warning: nested extern declaration of > ‘register_compat_prop’ [-Wnested-externs] > > You might want to install Xen development packages to catch such issues > earlier.
Sorry I have missed to check that. I'll definitely verify this in the following up posts. > > Test run: > > $ qemu-system-x86_64 -device migration,help > migration.skip-section-footer=bool > migration.store-global-state=bool > migration.only-migratable=bool > migration.skip-configuration=bool > > What would adding this device do? Hmm, the same answer in the other thread - I may need the compat bits and "-global", so I am using QDev for migration, not only QObject. Haven't investigate how difficult would it be to move these features from QDev into QObject. For now, do you think user_creatable=false an workable solution for this? We'll still see this help for sure, but at least we won't be able to create the device using "-device migration", also we won't see the migration entry in "-device help". Thanks, -- Peter Xu