On Thu, Jun 22, 2017 at 02:28:52PM -0300, Eduardo Habkost wrote: > On Thu, Jun 22, 2017 at 12:25:30PM +0800, Peter Xu wrote: > > On Wed, Jun 21, 2017 at 09:23:11AM -0300, Eduardo Habkost wrote: > > > On Wed, Jun 21, 2017 at 03:52:00PM +0800, Peter Xu wrote: > [...] > > > > diff --git a/vl.c b/vl.c > > > > index 59fea15..4452d7a 100644 > > > > --- a/vl.c > > > > +++ b/vl.c > > > > @@ -4571,6 +4571,7 @@ int main(int argc, char **argv, char **envp) > > > > exit (i == 1 ? 1 : 0); > > > > } > > > > > > > > > > I suggest a comment here warning about global property > > > registration ordering. e.g.: > > > > > > /* > > > * Ordering of global property registration matters: > > > * - machine compat_props should override accelerator-specific > > > * globals. > > > * - user-provided globals (-global, and global properties > > > * derived from other command-line options like -cpu) should > > > * override machine compat_props and accelerator-specific > > > * globals. > > > */ > > > > I have a standalone patch (next one) to unify these three places and > > added some comment. Would that suite? > > Sorry, I didn't see that patch when I was reviewing this one. It looks > good to me. Thanks!
Got it. Let me respin to fix the other places. Thanks! -- Peter Xu
