On 02/15/2017 11:05 AM, Paolo Bonzini wrote: [now several months later...]
> > > On 03/02/2017 16:47, Vladimir Sementsov-Ogievskiy wrote: >> Hi all! >> >> We really need exporting dirty bitmaps feature as well as remote >> get_block_status for nbd devices. So, here is minimalistic and restricted >> realization of 'structured reply' and 'block status' nbd protocol extension >> (as second is developed over the first the combined spec may be found here: >> https://github.com/NetworkBlockDevice/nbd/blob/extension-blockstatus/doc/proto.md) >> >> >> It should be minimal but fully compatible realization of the spec. > > This will require v2, but it seems pretty close already. This series now needs a major rebase on top of the cleanups already present for qemu 2.10. Realistically, I'm aiming to get my series [1] for NBD_OPT_GO into 2.10 (we have less than a week before soft freeze, so any reviews offered on that series will be appreciated), then the work on adding structured read and BLOCK_STATUS will probably be big enough that it will have to be 2.11 material, but getting it posted sooner rather than later will make it easier to fine-tune all the details. [1] https://lists.gnu.org/archive/html/qemu-devel/2017-07/msg01971.html And remember that in open source projects, review can often be the bottleneck - it does not scale to have reviews done solely by the people listed in MAINTAINERS. My personal rule of thumb is that I try to review 2 patches for every 1 that I submit, to make sure I'm not contributing to a black hole of unreviewed patch backlog (although no one will ever turn down a patch from a contributor unable to follow that advice). Other benefits of offering reviews: you quickly become more familiar with the code base, and you earn some name-recognition in the community (where it is more likely that your own patches get reviewed quickly because someone recognizes that you are a regular contributor). It's okay to state on a review that you are not familiar/comfortable with the code, and want a second reviewer to double-check your work. -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
