Hi, On 11.06.2017 09:48, Stefan Fritsch wrote: > Sending a break on a serial console can be useful for debugging the > guest. But not all chardev backends support sending breaks (only telnet > and mux do). The chardev-send-break command allows to send a break even > if using other backends. > > Signed-off-by: Stefan Fritsch <s...@sfritsch.de> > Acked-by: Dr. David Alan Gilbert <dgilb...@redhat.com> > --- > v2: added tests and Acked-by line [...] > diff --git a/tests/test-hmp.c b/tests/test-hmp.c > index 99e35ec15a..6dfa0c36e2 100644 > --- a/tests/test-hmp.c > +++ b/tests/test-hmp.c > @@ -22,6 +22,7 @@ static int verbose; > static const char *hmp_cmds[] = { > "boot_set ndc", > "chardev-add null,id=testchardev1", > + "chardev-send-break testchardev2", > "chardev-remove testchardev1", > "commit all", > "cpu-add 1",
Did you use "testchardev2" here on purpose, or should that have been a "testchardev1" instead? "testchardev2" is not a valid identifier in the HMP test, so this might not exercise the code path that you might have intended? Thomas