On Thu, Jul 20, 2017 at 06:28:11PM +0200, Lukáš Doktor wrote: > There is no need to define QEMUMonitorProtocol as old-style class. > > Signed-off-by: Lukáš Doktor <ldok...@redhat.com> > --- > scripts/qmp/qmp.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/scripts/qmp/qmp.py b/scripts/qmp/qmp.py > index bb4d614..68f3420 100644 > --- a/scripts/qmp/qmp.py > +++ b/scripts/qmp/qmp.py > @@ -30,7 +30,7 @@ class QMPTimeoutError(QMPError): > pass > > > -class QEMUMonitorProtocol: > +class QEMUMonitorProtocol(object):
I don't fully understand the consequences of changing to new-style classes when using old-style SuperClass.__init__() calls in the __init__(). Should we change QMPShell.__init__() to use super()? > > #: Socket's error class > error = socket.error > -- > 2.9.4 > -- Eduardo
