On 08/10/2017 10:55 AM, Daniel P. Berrange wrote: > Now that keycode numbers are converted to QKeyCodes immediately > when creating input events, the InputKeyEvent struct can be > changed to only accept a QKeyCode, instead of a KeyValue. > > Signed-off-by: Daniel P. Berrange <berra...@redhat.com> > ---
> +++ b/qapi-schema.json
> @@ -5747,7 +5747,7 @@
> # Since: 2.0
> ##
> { 'struct' : 'InputKeyEvent',
> - 'data' : { 'key' : 'KeyValue',
> + 'data' : { 'key' : 'QKeyCode',
> 'down' : 'bool' } }
Isn't this going to break backwards-compatibility of 'input-send-event'?
I think you have to keep the public API the same, even if you make the
conversion as early as possible to the preferred mapping form internally.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
