On 23.08.2017 10:39, Juan Quintela wrote: > We were using -1 instead of the real size because the functions check > what is bigger, size in bytes or the size of the iov. Recent gcc's > barf at this. > > Signed-off-by: Juan Quintela <quint...@redhat.com> > --- > tests/test-iov.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-)
While you're at it, could you maybe also adjust the comments in include/qemu/iov.h ? It currently says: * It is okay to use very large value for `bytes' since we're * limited by the size of the iovec anyway, provided that the * buffer pointed to by buf has enough space. One possible * such "large" value is -1 (sinice size_t is unsigned), * so specifying `-1' as `bytes' means 'up to the end of iovec'. ... and apparently -1 is not working anymore as expected. Maybe SIZE_MAX from stdint.h is a better choice? Thomas
