On 09/12/2017 04:31 PM, Eric Blake wrote: > Thanks to recent cleanups, most callers were scaling a return value > of sectors into bytes (the exception, in qcow2-bitmap, will be > converted to byte-based iteration later). Update the interface to > do the scaling internally instead. > > In qcow2-bitmap, the code was specifically checking for an error > to be -1; it is more robust to treat all negative values as an > error, but at the same time it is also easy enough to ensure we > return -1 (and not -512) on error. > > Signed-off-by: Eric Blake <ebl...@redhat.com> >
This patch now smells like a bugfix and a separate incremental feature enhancement. Do we need to backport the error-checking to a possible 2.10.1? If no: Reviewed-by: John Snow <js...@redhat.com>
