On 10/10/2017 12:44 PM, Martin Schrodt wrote: > Please see > > https://www.reddit.com/r/VFIO/comments/74vokw/improved_pulse_audio_driver_for_qemu/ > > for motivation, and more coverage. > > Changes: > > - Remove PA reader/writer threads from paaudio.c, and do IO from the audio > timer directly. > - Add 1 millisecond timers which interface with the HDA device, pulling and > pushing data > to and from it, to enable the guest driver to measure DMA timing by just > looking the > LPIB registers. > - Expose new configurable settings, such as TLENGTH and FRAGSIZE, plus > settings to > enable PA_STREAM_ADJUST_LATENCY for input and output device separately. > - Fix the input delay when first using the input device.
That's a lot of changes to be slamming in one patch. Any chance you can split it into a series of smaller patches that are easier to review individually? Perhaps one patch per item in your bulleted list is a good start for subdividing this into something that is not so massive. -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
