On Fri, Oct 20, 2017 at 01:41:59PM +0100, Peter Maydell wrote: > On 20 October 2017 at 13:13, Chen, Farrah <farrah.c...@intel.com> wrote: > > Hi, > > > > When I build qemu with commit from aef45d51d1204f3335fb99de6658e0c5612c2b67 > > to the latest one, the following error occurred: > > > > tsocks git clone git://git.qemu.org/qemu.git > > cd qemu > > > > ./configure --target-list=x86_64-softmmu --enable-kvm --enable-vnc > > --disable-gtk --enable-libusb --enable-numa --disable-sdl > > make > > GEN config-host.h > > GIT dtc > > GEN trace/generated-tcg-tracers.h > > GEN trace/generated-helpers-wrappers.h > > GEN trace/generated-helpers.h > > GEN module_block.h > > GEN trace/generated-helpers.c > > make: *** [git-submodule-update] Error 1 > > Dan -- I thought we were going to not have the git-submodule.sh > script throw away the errors from git, but the version in > master still seems to do that...
Urgh, yes, we did fix that, but it seems it got lost in one of the rebases somewhere along the way. I'll send a patch to fix it. > (The fact you needed to say 'tsocks git clone...' on your > original command suggests to me that the problem is that > plain 'git submodule update' can't access the git repo.) Yep, creating the wrapper script called 'git' that runs 'exec tsocks /usr/bin/git "$@"' is the way to deal with this for QEMU, and indeed any project using git. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
