On 10/20/2017 09:10 AM, Daniel P. Berrange wrote: > Some users can't run a bare 'git' command, due to need for a transparent > proxying solution such as 'tsocks'. This adds an argument to configure to > let users specify such a thing: > > ./configure --with-git="tsocks git" > > The submodule script is also updated to give the user a hint about using this > flag, if we fail to checkout modules.
Does my hint about using 'git config url.XYZ.insteadof git://...' do the
trick without needing this patch?
>
> Signed-off-by: Daniel P. Berrange <berra...@redhat.com>
> ---
> Makefile | 4 ++--
> configure | 5 +++++
> scripts/git-submodule.sh | 30 +++++++++++++++++++++++++-----
> 3 files changed, 32 insertions(+), 7 deletions(-)
>
> +++ b/scripts/git-submodule.sh
> @@ -3,14 +3,19 @@
> # This code is licensed under the GPL version 2 or later. See
> # the COPYING file in the top-level directory.
>
> -set -e
> -
Is the change of dropping 'set -e' and adding 'error' worth doing as an
independent patch?
> substat=".git-submodule-status"
> update)
> - git submodule update --init $modules 1>/dev/null
> - git submodule status $modules > "${substat}"
> + $GIT submodule update --init $modules 1>/dev/null
style of whether 1> or plain > is sufficient.
But in spite of my comments, the patch looks correct. So if we agree
that we want it, you can add:
Reviewed-by: Eric Blake <ebl...@redhat.com>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
