On Fri, 10 Dec 2010 16:20:34 +0100 Markus Armbruster <arm...@redhat.com> wrote:
> [Note cc: Dan, Avi] > > Luiz Capitulino <lcapitul...@redhat.com> writes: > > > On Tue, 23 Nov 2010 10:43:48 -0200 > > Luiz Capitulino <lcapitul...@redhat.com> wrote: > > > >> On Tue, 23 Nov 2010 13:41:26 +0800 > >> Wen Congyang <we...@cn.fujitsu.com> wrote: > >> > >> > The args_type of migrate_set_speed in qmp-commands.hx is wrong. > >> > When we set migrate speed by json, qemu will be core dumped. > >> > > >> > Signed-off-by: Wen Congyang > >> > >> Nice catch. > >> > >> Was caused by 07de3e60b05 and hence affects master only. Could you please > >> mention that in the commit log? Also, your email address is missing > >> in the signed-off-by line. > > > > There's another problem there: we used to accept a json number but now we > > accept only a json integer. > > > > Markus, are you aware of this change? > > I pointed out the incompatible change in my review[*] of the offending > patch: Ok, I can remember now. I really think this is a small improvement and I doubt there's any client out there depending on this. > This isn't backwards bug-compatible. > > Before, a client could send any number. Any fractional part was > ignored. > > Now, the number must be an integer. Other numbers are rejected. > > I don't care myself, but others have argued most forcefully for keeping > QMP fully backward compatible from 0.13 on, so they might object. > > "Others" did not object, so this went in. Not released yet, so it's not > too late to object. > > > [*] http://lists.gnu.org/archive/html/qemu-devel/2010-09/msg01905.html >