Le 04/11/2017 à 22:20, Stafford Horne a écrit : > Hello, > > On Fri, Nov 03, 2017 at 09:26:22PM +0100, Laurent Vivier wrote: >> Signed-off-by: Laurent Vivier <laur...@vivier.eu> > > There is no commit body here, do we need one? I can see in your cover letter > its mentioned this was revealed after enabling "USE_SOFTFLOAT_STRUCT_TYPES". > > However, I'm just being curious why is this an issue? In softfloat I assume > we > pack our own floats so having the type that goes into a uint32 register > wouldnt > make much difference right?
It's not an issue. It's for consistency. We can store a float32 in an uint32_t, but it's better to store float32 in float32 type. And as said in include/fpu/softfloat.h: "Use structures for soft-float types. This prevents accidentally mixing them with native int/float types." Thanks, Laurent
