On Wed, 15 Nov 2017 07:59:31 +0100 Thomas Huth <th...@redhat.com> wrote:
> On 15.11.2017 00:33, David Gibson wrote: > [...] > [...] > [...] > [...] > [...] > [...] > [...] > [...] > > David, I agree with all of your comments - I had similar thoughts when I > was working with the code. However, as you already indicated, to address > all of this, we would need to rewrite most parts of this device. That's > out of my scope here - I wanted to keep the changes as minimal as > possible, so that there is a chance that we can get the endianness > problem still fixed for 2.11. So do you think that the patch is OK for > this? ... otherwise, I think I'll rather send a patch that removes the > vmxnet3 from the pxe-tester again - then it won't be tested anymore and > we won't get anymore endianness test failures. Yeah, good point. Getting a fix in place is more important than making the existing stuff more elegant. Reviewed-by: David Gibson <dgib...@redhat.com> -- David Gibson <dgib...@redhat.com> Principal Software Engineer, Virtualization, Red Hat
pgpglqSBkYlZq.pgp
Description: OpenPGP digital signature